Add options for basic auth to haproxy input #4657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielnelson
reviewed
Sep 7, 2018
plugins/inputs/haproxy/haproxy.go
Outdated
| addr = u.String() | ||
| } | ||
|
|
||
| if g.Username != "" { |
There was a problem hiding this comment.
Set if either username or password is not empty, since some folks only have a password.
glinton
changed the title
danielnelson
added
the
feat
rgitzel
pushed a commit
to rgitzel/telegraf
that referenced
this pull request
Oct 17, 2018
otherpirate
pushed a commit
to otherpirate/telegraf
that referenced
this pull request
Mar 15, 2019
otherpirate
pushed a commit
to otherpirate/telegraf
that referenced
this pull request
Mar 15, 2019
dupondje
pushed a commit
to dupondje/telegraf
that referenced
this pull request
Apr 22, 2019
athoune
pushed a commit
to bearstech/telegraf
that referenced
this pull request
Apr 17, 2020
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4509
Formerly users who enabled auth on their haproxy servers were required to set the username/password in the url. Now it is added separately. Older config styles (
https://user:pass@host/haproxy?stats) won't break and won't print login info in logs on bad connections.