Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved #4768: Added UUID to VMs #4769

Merged
merged 1 commit into from
Oct 1, 2018
Merged

Resolved #4768: Added UUID to VMs #4769

merged 1 commit into from
Oct 1, 2018

Conversation

prydin
Copy link
Contributor

@prydin prydin commented Sep 28, 2018

Required for all PRs:

  • [ X ] Signed CLA.
  • [ X ] Associated README.md updated.
  • [ X ] Has appropriate unit tests.

Resolved #4768: Added UUID to VMs.
BIOS UUIDs are needed to correlate metrics from inside the VM to metrics gathered from vSphere. They were originally not included and users raised this as an issue. This PR addresses that issue and adds code to emit BIOS UUIDs when available.

@danielnelson
Copy link
Contributor

UUIDs can often be problematic because they, by design, have high cardinality. We should think about when the BIOS UUID is unique and when it changes. Is it different each time you start a VM? Does it ever change during the VMs lifetime?

@prydin
Copy link
Contributor Author

prydin commented Sep 28, 2018

They are the same for the lifetime of the VM. It doesn't change when a machine is restarted.

@prydin
Copy link
Contributor Author

prydin commented Oct 1, 2018

Any indication as to if/when this will be merged? Will it make it into the next maintenance release?

@danielnelson
Copy link
Contributor

This is a little bit borderline for a patch release since it adds a new tag but I think it is minor enough and the plugin is new enough that we can add it.

@danielnelson danielnelson added this to the 1.8.1 milestone Oct 1, 2018
@danielnelson danielnelson merged commit 797fbf7 into influxdata:master Oct 1, 2018
danielnelson pushed a commit that referenced this pull request Oct 1, 2018
@randallt
Copy link

randallt commented Oct 3, 2018

@prydin Can you describe the scenario a bit more on why a UUID is required to correlate?

@danielnelson danielnelson added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin area/vsphere labels Oct 3, 2018
@prydin
Copy link
Contributor Author

prydin commented Oct 3, 2018

The BIOS UUID is the only identifier that's visible both from the vCenter and from inside the guest OS. On Linux, you can get it using the dmidecode command. I've seen use case where there's a need to correlate metrics from within the guest to what vCenter sees.

rgitzel pushed a commit to rgitzel/telegraf that referenced this pull request Oct 17, 2018
otherpirate pushed a commit to otherpirate/telegraf that referenced this pull request Mar 15, 2019
otherpirate pushed a commit to otherpirate/telegraf that referenced this pull request Mar 15, 2019
dupondje pushed a commit to dupondje/telegraf that referenced this pull request Apr 22, 2019
athoune pushed a commit to bearstech/telegraf that referenced this pull request Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/vsphere feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants