-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolved #4768: Added UUID to VMs #4769
Conversation
UUIDs can often be problematic because they, by design, have high cardinality. We should think about when the BIOS UUID is unique and when it changes. Is it different each time you start a VM? Does it ever change during the VMs lifetime? |
They are the same for the lifetime of the VM. It doesn't change when a machine is restarted. |
Any indication as to if/when this will be merged? Will it make it into the next maintenance release? |
This is a little bit borderline for a patch release since it adds a new tag but I think it is minor enough and the plugin is new enough that we can add it. |
(cherry picked from commit 797fbf7)
@prydin Can you describe the scenario a bit more on why a UUID is required to correlate? |
The BIOS UUID is the only identifier that's visible both from the vCenter and from inside the guest OS. On Linux, you can get it using the |
Required for all PRs:
Resolved #4768: Added UUID to VMs.
BIOS UUIDs are needed to correlate metrics from inside the VM to metrics gathered from vSphere. They were originally not included and users raised this as an issue. This PR addresses that issue and adds code to emit BIOS UUIDs when available.