Non-transparent transport of syslog messages #5148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify syslog input plugin to support non-transparent framing technique (RFC6587), too. Modify other existing modalities to match new go-syslog interfaces. Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
RFC5425 tests need to be updated accordingly. Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
1 test case, all combinations. Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
leodido
force-pushed
the
feature/non-transparent-syslog
branch
from
e40ec04 to
50af8bf
Compare
danielnelson
approved these changes
Dec 17, 2018
goller
approved these changes
Dec 17, 2018
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
danielnelson
pushed a commit
that referenced
this pull request
Dec 18, 2018
(cherry picked from commit 697381d)
trevorwhitney
pushed a commit
to trevorwhitney/telegraf
that referenced
this pull request
Feb 14, 2019
otherpirate
pushed a commit
to otherpirate/telegraf
that referenced
this pull request
Mar 15, 2019
otherpirate
pushed a commit
to otherpirate/telegraf
that referenced
this pull request
Mar 15, 2019
dupondje
pushed a commit
to dupondje/telegraf
that referenced
this pull request
Apr 22, 2019
bitcharmer
pushed a commit
to bitcharmer/telegraf
that referenced
this pull request
Oct 18, 2019
athoune
pushed a commit
to bearstech/telegraf
that referenced
this pull request
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the non-transparent transport of syslog messages for the syslog input plugin. Refs #4482
It depends on an upcoming new go-syslog version influxdata/go-syslog#18 soon to be released.
Needs some testing yet.
Please do not merge yet.
Required for all PRs: