[inputs.vsphere] Resolved issue 4790 (Resource whitelisting) #5165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Don't stop collection on partial error * Compute average if query returned multiple samples for a metric
…roblems with some versions of vCenter
prydin
changed the title
|
Let's do #5113 separately and then rebase this once it is merged. |
…g from GetClient(), fixed discovered object counting
|
@danielnelson @glinton Is the plan still to pull this in by 1.10? I haven't seen much movement on it. |
|
I'd like to include it, can you rebase? |
| @@ -209,7 +290,11 @@ func TestParseConfig(t *testing.T) { | |||
| require.NotNil(t, tab) | |||
| } | |||
|
|
|||
| <<<<<<< HEAD | |||
|
Fixed the merge issues, but circleci is failing at a step where it's trying to download some package. Don't think that's related to this PR. Maybe something intermittent in the test harness? |
| return r.finder.FindAll(ctx, r.resType, r.paths, dst) | ||
| } | ||
|
|
||
| func init() { |
There was a problem hiding this comment.
Optional: I don't think there is a reason to use the init function, I'd just set these up top with the variable.
danielnelson
added
feat
trevorwhitney
pushed a commit
to trevorwhitney/telegraf
that referenced
this pull request
Feb 14, 2019
otherpirate
pushed a commit
to otherpirate/telegraf
that referenced
this pull request
Mar 15, 2019
otherpirate
pushed a commit
to otherpirate/telegraf
that referenced
this pull request
Mar 15, 2019
dupondje
pushed a commit
to dupondje/telegraf
that referenced
this pull request
Apr 22, 2019
bitcharmer
pushed a commit
to bitcharmer/telegraf
that referenced
this pull request
Oct 18, 2019
athoune
pushed a commit
to bearstech/telegraf
that referenced
this pull request
Apr 17, 2020
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
Addresses issues #4789 and #4989 and allows users to select resources using inventory paths. Each resource type is given a *_include clause in the config file that looks like this:
@glinton and @danielnelson This PR also has the changes provided in #5113. I'd love to get this in for 1.10 and it would probably make sense to merge this one and retire #5113 in that case.