Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deliver empty metric tracking group immediately #5176

Merged
merged 1 commit into from
Dec 27, 2018

Conversation

danielnelson
Copy link
Contributor

If an empty array of tracking metrics is added to the accumulator, just mark it as immediately delivered and send delivery notification. This avoids potential errors and avoids the input needing to check for empty groups.

closes #5170

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@danielnelson danielnelson added the fix pr to fix corresponding bug label Dec 20, 2018
@danielnelson danielnelson added this to the 1.9.2 milestone Dec 20, 2018
@danielnelson danielnelson requested a review from glinton December 20, 2018 22:11
@danielnelson danielnelson merged commit 7497a20 into master Dec 27, 2018
@danielnelson danielnelson deleted the deliver-empty-tracking-groups branch December 27, 2018 03:36
trevorwhitney pushed a commit to trevorwhitney/telegraf that referenced this pull request Feb 14, 2019
otherpirate pushed a commit to otherpirate/telegraf that referenced this pull request Mar 15, 2019
otherpirate pushed a commit to otherpirate/telegraf that referenced this pull request Mar 15, 2019
dupondje pushed a commit to dupondje/telegraf that referenced this pull request Apr 22, 2019
bitcharmer pushed a commit to bitcharmer/telegraf that referenced this pull request Oct 18, 2019
athoune pushed a commit to bearstech/telegraf that referenced this pull request Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AMQP consumer stopped if message is empty
2 participants