Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input Plugin: Adding TTL field for Ping plugin #5556

Merged
merged 8 commits into from
Mar 8, 2019
Merged

Input Plugin: Adding TTL field for Ping plugin #5556

merged 8 commits into from
Mar 8, 2019

Conversation

dheerajdwivedi
Copy link
Contributor

@dheerajdwivedi dheerajdwivedi commented Mar 8, 2019

Feature request 5537

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

plugins/inputs/ping/ping.go Outdated Show resolved Hide resolved
@glinton glinton added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Mar 8, 2019
@danielnelson
Copy link
Contributor

Let's call the new field just ttl.

@dheerajdwivedi
Copy link
Contributor Author

dheerajdwivedi commented Mar 8, 2019

Let's call the new field just ttl.

Agreed and done.

That was a quick hack I had to do in last commit as build failed due to format check.
Not sure why format check passed in my local and failed while build.
Refer this commit.

@dheerajdwivedi
Copy link
Contributor Author

@danielnelson Looks like a false alarm. Can you please re-trigger the build.

@danielnelson danielnelson added this to the 1.11.0 milestone Mar 8, 2019
@danielnelson danielnelson merged commit 8015502 into influxdata:master Mar 8, 2019
@danielnelson danielnelson mentioned this pull request Mar 8, 2019
otherpirate pushed a commit to otherpirate/telegraf that referenced this pull request Mar 15, 2019
otherpirate pushed a commit to otherpirate/telegraf that referenced this pull request Mar 15, 2019
dupondje pushed a commit to dupondje/telegraf that referenced this pull request Apr 22, 2019
hwaastad pushed a commit to hwaastad/telegraf that referenced this pull request Jun 13, 2019
bitcharmer pushed a commit to bitcharmer/telegraf that referenced this pull request Oct 18, 2019
athoune pushed a commit to bearstech/telegraf that referenced this pull request Apr 17, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants