[inputs/diskio] Fix how major and minor identifiers of block devices are read. #5566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soulou
changed the title
The current implementation assure that the major and the minor are coded on one byte. But they are not: ``` brw-rw---- 1 root disk 252, 290 Feb 25 11:36 dm-290 ``` 290 as minor in this example is over 1 byte. So after wondering why all my devices iops weren't correctly stored, I found out that several points were added for some disks. For `dm-290` it was overriding `252:34`, instead of getting udev stats for `252:290`. The solution is here: https://sites.uclouvain.be/SystInfo/usr/include/sys/sysmacros.h.html The implementation is directly taken from this, fixing my bug.
Soulou
force-pushed
the
fix/diskio/major-minor
branch
from
513a392 to
92b01ab
Compare
|
Could we use these functions to extract the major/minor numbers? |
|
Definitely, I'm doing it now |
|
done |
glinton
approved these changes
Mar 15, 2019
|
@Soulou could you look into this build error on mipsle? |
For most platforms, stat.Rdev is already a uint64 so this is without any effect for linux,mipsle, unix.Stat_t.Rdev is a uint32, but the way to compute major and minor doesn't change, casting the uint32 has no impact either
|
done :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation assure that the major and the minor are
coded on one byte. But they are not:
290 as minor in this example is over 1 byte.
So after wondering why all my devices iops weren't correctly stored,
I found out that several points were added for some disks. For
dm-290it was overriding
252:34, instead of getting udev stats for252:290.The solution is here:
https://sites.uclouvain.be/SystInfo/usr/include/sys/sysmacros.h.html
The implementation is directly taken from this, fixing my bug.