-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse the Redis optional replication section redis_replication measuremet #5921
Parse the Redis optional replication section redis_replication measuremet #5921
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you document the new redis_replication
measurement in the readme? thanks
@glinton done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, can you also update theses to use the new format:
### Metrics
- measurement1
- tags:
- tag1 (optional description)
- tag2
- fields:
- field1 (type, unit)
- field2 (float, percent)
+ measurement2
a773cd9
to
e8506e2
Compare
@danielnelson @glinton I believe I addressed all the feedback, please review. |
In the future, once a review has started, please refrain from force-pushing as we don't always have time for a compete re-review. thanks |
Any update? The code is ready. Also, is 1.13 the appropriate target? I feel this is a minor change and could likely be included in the 1.12.x line |
Thanks @adamflott, sorry this will need to go out in 1.13 since we try to make as few changes as possible to the release branches to avoid introducing new bugs. |
Parse the Redis replication nodes into individual pieces (ip, port, offset, lag) instead of a single string
Required for all PRs: