Added support for custom attributes #5971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Don't stop collection on partial error * Compute average if query returned multiple samples for a metric
…roblems with some versions of vCenter
…g from GetClient(), fixed discovered object counting
danielnelson
added
feat
plugins/parsers/wavefront/parser.go
Outdated
| @@ -98,6 +98,8 @@ func (p *PointParser) Parse(buf []byte) ([]telegraf.Metric, error) { | |||
| buf = append(buf, []byte("\n")...) | |||
| } | |||
|
|
|||
| //log.Printf("D! [parsers.wavefront] Received data: %s", string(buf)) | |||
|
@danielnelson This PR will most likely generate a nasty merge with the vSAN stuff that @YuxinZhou is working on. How do you want me to handle that? Just wait for her merge to clear and then clean up the merge on my fork? Or you want us to merge our two branches into one? |
|
Unfortunately, I'm not going to have time to help finish the vSAN code for the upcoming 1.12 release. Let's merge this in and have @YuxinZhou base his code on it. |
bitcharmer
pushed a commit
to bitcharmer/telegraf
that referenced
this pull request
Oct 18, 2019
athoune
pushed a commit
to bearstech/telegraf
that referenced
this pull request
Apr 17, 2020
idohalevi
pushed a commit
to idohalevi/telegraf
that referenced
this pull request
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
Custom attributes is an important construct that allows administrators to tag resources workloads according to custom schemes. This can be used to group assets, tie containers to VMs, classify workload security requirements among many other things. Being able to use these in queries in target solutions such as InfluxDB has been desired by several users of the vSphere plugin.
Custom attribute collection is controlled by the
custom_attribute_includeandcustom_attribute_excludeconfiguration settings.