Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation regarding collecting invalid certs #6139

Closed
wants to merge 2 commits into from

Conversation

glinton
Copy link
Contributor

@glinton glinton commented Jul 18, 2019

Resolves #6066

I wonder if a better solution would be to always enable insecure_skip_verify. The tests set it by default.

@glinton glinton added the fix pr to fix corresponding bug label Jul 18, 2019
@danielnelson
Copy link
Contributor

The one thing having insecure_skip_verify = false does for us now is give some sort of indication if the certificate is invalid. Unfortunately it's not a positive claim, the metric just stops being emitted.

Originally we wanted to report if the cert was valid but we removed it because our check could report valid for some invalid certs. If we research the right arguments to x509.Verify( I think we could potentially add validity information and remove this option.

One more thing, I notice that even with insecure_skip_verify = true you can't get a self signed certificate over HTTP (assuming you don't have the CA cert for it).

@glinton
Copy link
Contributor Author

glinton commented Jul 23, 2019

Preferring 6143 over this

@glinton glinton closed this Jul 23, 2019
@glinton glinton deleted the bugfix/6066 branch July 23, 2019 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

x509_cert: Error when site SSL is not valid
2 participants