Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow influxdb_listener to keep the database name from the query string if supplied #6257

Merged
merged 5 commits into from
Aug 16, 2019
Merged

Allow influxdb_listener to keep the database name from the query string if supplied #6257

merged 5 commits into from
Aug 16, 2019

Conversation

morfien101
Copy link
Contributor

Updating to allow the users to keep the database that gets sent in the query string. See issue #6253

Adding a test for the code change
Adding new configuration to the README.
Adding toml tags to make it like the rest of the plugins.

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@morfien101
Updating to allow the users to keep the database that gets sent in th…
c94ce3c 
…e query string.

Adding a test for the code change
Adding new configuration to the README.
Adding toml tags to make it like the rest of the plugins.
danielnelson
danielnelson suggested changes Aug 14, 2019
View reviewed changes
Copy link
Contributor

@danielnelson danielnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are starting to settle on a similar pattern for adding extra data to ParserInput plugins, so most of my comments are around adopting this pattern more closely.

plugins/inputs/influxdb_listener/README.md Outdated Show resolved Hide resolved
plugins/inputs/influxdb_listener/README.md Outdated Show resolved Hide resolved
plugins/inputs/influxdb_listener/http_listener.go Outdated Show resolved Hide resolved
@danielnelson danielnelson added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Aug 14, 2019
@danielnelson danielnelson added this to the 1.12.0 milestone Aug 16, 2019
@danielnelson danielnelson merged commit beb788b into influxdata:master Aug 16, 2019
@morfien101 morfien101 deleted the influxdb_listener_keep_database branch August 19, 2019 08:46
@danielnelson danielnelson mentioned this pull request Aug 28, 2019
Closed
bitcharmer pushed a commit to bitcharmer/telegraf that referenced this pull request Oct 18, 2019
@morfien101 @bitcharmer
Add database_tag option to influxdb_listener to add database from que…
8e71c6c 
…ry string (influxdata#6257)
athoune pushed a commit to bearstech/telegraf that referenced this pull request Apr 17, 2020
@morfien101
Add database_tag option to influxdb_listener to add database from que…
538efe4 
…ry string (influxdata#6257)
idohalevi pushed a commit to idohalevi/telegraf that referenced this pull request Sep 29, 2020
@morfien101
Add database_tag option to influxdb_listener to add database from que…
7d5dd27 
…ry string (influxdata#6257)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielnelson danielnelson danielnelson approved these changes

Assignees
No one assigned
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@morfien101 @danielnelson