Fix parsing multiple metrics on the first line of tailed file #6289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielnelson
force-pushed
the
fix-multiple-metrics-tail
branch
from
69d8748 to
244a56a
Compare
danielnelson
force-pushed
the
fix-multiple-metrics-tail
branch
from
244a56a to
6c0ab21
Compare
glinton
approved these changes
Aug 21, 2019
plugins/inputs/tail/tail.go
Outdated
| } | ||
|
|
||
| if m != nil { | ||
| metrics = append(metrics, m) |
There was a problem hiding this comment.
Nit: use metrics = []telegraf.Metric{m}
bitcharmer
pushed a commit
to bitcharmer/telegraf
that referenced
this pull request
Oct 18, 2019
dloucasfx
pushed a commit
to signalfx/telegraf
that referenced
this pull request
Apr 14, 2020
dloucasfx
pushed a commit
to signalfx/telegraf
that referenced
this pull request
Apr 14, 2020
…data#6289) Fix unit test Signed-off-by: Dani Louca <dlouca@splunk.com>
dloucasfx
pushed a commit
to signalfx/telegraf
that referenced
this pull request
Apr 14, 2020
athoune
pushed a commit
to bearstech/telegraf
that referenced
this pull request
Apr 17, 2020
idohalevi
pushed a commit
to idohalevi/telegraf
that referenced
this pull request
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick fix for parsing multiple metrics on the first line of a file without breaking the special csv behavior. #6160 will fix this in a better way, but needs changes around performance and reporting errors during construction first.
closes #6138
Required for all PRs: