Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow multiple certificates on same file for x509 input #6695

Merged
merged 2 commits into from
Nov 25, 2019
Merged

Allow multiple certificates on same file for x509 input #6695

merged 2 commits into from
Nov 25, 2019

Conversation

jonathannegrin
Copy link
Contributor

@jonathannegrin jonathannegrin commented Nov 21, 2019 •
edited
Loading

Allow to load multiple certificates from the same file with the x509 input

Required for all PRs:

  • Signed CLA.
  • [] Associated README.md updated. (Not needed)
  • Has appropriate unit tests.

@jonathannegrin
Allow multiple certificates on same file for x509 input
cc6ad89 
Allow to load multiple certificates from the same file with the x509 input
danielnelson
danielnelson suggested changes Nov 22, 2019
View reviewed changes
Copy link
Contributor

@danielnelson danielnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pr, this will be very useful.

plugins/inputs/x509_cert/x509_cert.go Show resolved Hide resolved
plugins/inputs/x509_cert/x509_cert_test.go Outdated Show resolved Hide resolved
@danielnelson danielnelson added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Nov 22, 2019
@danielnelson danielnelson added this to the 1.13.0 milestone Nov 22, 2019
@jonathannegrin
Trim spaces and include more test cases
bc68436 
Trim spaces on x509 content file and add more test cases
@danielnelson danielnelson merged commit c53d538 into influxdata:master Nov 25, 2019
athoune pushed a commit to bearstech/telegraf that referenced this pull request Apr 17, 2020
@jonathannegrin
Allow multiple certificates per file in x509_cert input (influxdata#6695
782ff59 
)
idohalevi pushed a commit to idohalevi/telegraf that referenced this pull request Sep 29, 2020
@jonathannegrin
Allow multiple certificates per file in x509_cert input (influxdata#6695
85e1464 
)
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
@jonathannegrin @danielnelson
Allow multiple certificates per file in x509_cert input (influxdata#6695
fdb9a23 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielnelson danielnelson danielnelson approved these changes

Assignees
No one assigned
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jonathannegrin @danielnelson