Set message timestamp to the metric time in kafka output #6746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielnelson
added
the
feat
johnatannvmd
reviewed
Dec 3, 2019
| @@ -316,13 +318,14 @@ func (k *Kafka) Write(metrics []telegraf.Metric) error { | |||
| for _, metric := range metrics { | |||
| buf, err := k.serializer.Serialize(metric) | |||
| if err != nil { | |||
| log.Printf("D! [outputs.kafka] Could not serialize metric: %v", err) | |||
| k.Log.Debugf("Could not serialize metric: %v", err) | |||
There was a problem hiding this comment.
I think it's more like error than debug information. Because it's about data loss, and not about "how and where?". It's my opinion.
There was a problem hiding this comment.
No change is made here to the level, so I think we can handle this in a separate issue. I think it may have been added at some point due to metrics without fields, need to do some research on the history.
athoune
pushed a commit
to bearstech/telegraf
that referenced
this pull request
Apr 17, 2020
idohalevi
pushed a commit
to idohalevi/telegraf
that referenced
this pull request
Sep 29, 2020
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #6696
Required for all PRs: