Kubernetes input plugin PodLabels #6764
Conversation
|
|
||
| for i := 0; i < len(podapi.Items); i++ { | ||
| var meta PodInfo | ||
| err = json.Unmarshal(podapi.Items[i]["metadata"], &meta) |
There was a problem hiding this comment.
Add the PodInfo to the Podlist object, then you can skip this second phase of parsing. Keep all the labels at this point and we can see if they match the filter later when we add the tags.
|
|
||
| type PodInfo struct { | ||
| Name string `json:"name"` | ||
| NameSpace string `json:"namespace"` |
|
|
||
| import "encoding/json" | ||
|
|
||
| type Podlist struct { |
There was a problem hiding this comment.
Suggest naming this Pods since this contains a list.
| @@ -42,6 +48,11 @@ var sampleConfig = ` | |||
| ## OR | |||
| # bearer_token_string = "abc_123" | |||
|
|
|||
| # Labels to include and exclude | |||
| # An empty array for include and exclude will include all labels | |||
| label_include = [] | |||
There was a problem hiding this comment.
This deviates from other existing plugins, but in order to avoid adding unwanted data I think we need to default to exclude all labels. In order to make this work, initialize the exclude filter in the init() function "*":
func init() {
inputs.Add("kubernetes", func() telegraf.Input {
return &Kubernetes{
LabelInclude: []string{},
LabelExclude: []string{"*"},
}
})
}Then, comment out the default values here:
# label_include = []
# label_exclude = ["*"]If a user defines them again like so it will still include all, this is okay:
label_include = []
label_exclude = []| @@ -209,6 +263,14 @@ func buildPodMetrics(summaryMetrics *SummaryMetrics, acc telegraf.Accumulator) { | |||
| "container_name": container.Name, | |||
| "pod_name": pod.PodRef.Name, | |||
| } | |||
| for i := range podInfo { | |||
There was a problem hiding this comment.
Use the named range variables: for _, info := range podInfo {
danielnelson
added
area/k8s
feat
|
If fixed the problems you mentioned. |
By calling the Endpoint
/podsi added a function that collects the Labels of all Pods and adds them to their tags.Required for all PRs: