Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input Sqlserver -binary hash converted to string #6818

Merged
merged 1 commit into from
Dec 30, 2019

Conversation

Trovalo
Copy link
Collaborator

@Trovalo Trovalo commented Dec 20, 2019

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

With reference to issue #6679, this will convert the binary data to strings, in order to make them more meaningful once stored.
The involved fields are:

  • query_hash
  • query_plan_hash

The question about turning them from fields to tags is still open

closes #6679

@Trovalo Trovalo changed the title binary hash converted to string Input Sqlserver -binary hash converted to string Dec 20, 2019
@Trovalo
Copy link
Collaborator Author

Trovalo commented Dec 24, 2019

idk why but the error is on the "TestGrokParseLogFiles" which has not been touched.
sql server related tests have passed.

@danielnelson
Copy link
Contributor

Sorry, this is an intermittently failing test I need to look into, lately many more failures with it. For now I retriggered the tests.

One question on this pull request, did this change cause the fields to be reported as tags? It isn't a problem either way, but if it did I'll just want to add a note to the release.

@danielnelson danielnelson added area/sqlserver fix pr to fix corresponding bug labels Dec 27, 2019
@Trovalo
Copy link
Collaborator Author

Trovalo commented Dec 29, 2019

This just fix the data type.
I may open a different pull request to set the fields as tags

@danielnelson danielnelson added this to the 1.13.1 milestone Dec 30, 2019
@danielnelson danielnelson merged commit 3d8940e into influxdata:master Dec 30, 2019
danielnelson pushed a commit that referenced this pull request Dec 30, 2019
@Trovalo Trovalo deleted the QueryHashAsString branch December 30, 2019 20:35
athoune pushed a commit to bearstech/telegraf that referenced this pull request Apr 17, 2020
idohalevi pushed a commit to idohalevi/telegraf that referenced this pull request Sep 29, 2020
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/sqlserver fix pr to fix corresponding bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non textual field string data in sqlserver plugin with SqlRequests query
2 participants