Report rabbitmq_node measurement and return on gather error #6819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reimda
reviewed
Jan 2, 2020
| } | ||
|
|
||
| var memory MemoryResponse | ||
| err = r.requestJSON("/api/nodes/"+node.Name+"/memory", &memory) |
There was a problem hiding this comment.
Is it ok to make another request when the health check failed? Now that we have "defer wg.done()" shouldn't we return early when health check fails?
There was a problem hiding this comment.
Second request is safe to do, but is somewhat likely to fail in the case of an earlier error from requestJSON. It is probably best to not create a partial metric, so I'll change this to return early.
reimda
approved these changes
Jan 3, 2020
danielnelson
added a commit
that referenced
this pull request
Jan 3, 2020
(cherry picked from commit 0cf94cf)
athoune
pushed a commit
to bearstech/telegraf
that referenced
this pull request
Apr 17, 2020
idohalevi
pushed a commit
to idohalevi/telegraf
that referenced
this pull request
Sep 29, 2020
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #6814
Required for all PRs: