Add support for credentials file to nats_consumer and nats output #7022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @ripienaar, interested to see the new features, just go ahead and add your changes on top of this changeset and we can merge them in one go. |
danielnelson
added
the
feat
|
@danielnelson OK am about done here, mainly I added Additionally moved away from the now deprecated method of connecting via opts. |
plugins/outputs/nats/README.md
Outdated
Comment on lines
12
to
15
| # credentials = "/etc/telegraf/nats.creds | ||
|
|
There was a problem hiding this comment.
Can you add this example to the nats_consumer README?
|
I've updated the comments etc, it's ready to merge if you agree |
danielnelson
changed the title
athoune
pushed a commit
to bearstech/telegraf
that referenced
this pull request
Apr 17, 2020
idohalevi
pushed a commit
to idohalevi/telegraf
that referenced
this pull request
Sep 29, 2020
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to make some follow up PRs to support some of the modern NATS 2.0 security
features and thought I'd start by updating dependencies first before doing those changes
Required for all PRs: