-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Input prometheus, use the same timestamp per call if no time is provided #7063
Input prometheus, use the same timestamp per call if no time is provided #7063
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I have a suggestion on the comment that I think might clarify it a bit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's take this a step further and call time.Now() only once and pass the time down into both makeQuantilesV2 and makeBucketsV2, this will give us full consistency for the query.
avoid the chance to have different timestamp during iteration of each metric for one http.Response Signed-off-by: Anthony ARNAUD <github@anthony-arnaud.fr>
4da902f
to
2c98cd0
Compare
Do you now when the next release is plan ? Can I made a PR to have a bugfix on 1.12 or 1.13 soon ? |
As soon as it's merged we'll back port it to 1.13.x (probably 1.13.4). Just waiting for @danielnelson to approve. |
(cherry picked from commit 8c99dc7)
thanks @danielnelson for quick release. It's appreciate |
Sorry about this, currently it takes us a bit of time to get the official containers updated and unfortunately it isn't an automatic process. There are two places you can keep an eye on for progress updates:
|
avoid the chance to have different timestamp during iteration of each
metric for one http.Response
This PR, fix an issue we discover. some time during the iteration of metrics, the timestamp change to pass to the next second and our metrics aren't align.
This only applied if TimestampMs is not provided in the prometheus metrics
Required for all PRs: