pugins/outputs/influxdb: Prevent runtime panic. #715
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -48,7 +48,7 @@ var sampleConfig = ` | |||
| urls = ["http://localhost:8086"] # required | |||
| ### The target database for metrics (telegraf will create it if not exists) | |||
| database = "telegraf" # required | |||
| ### Precision of writes, valid values are n, u, ms, s, m, and h | |||
| ### Precision of writes, valid values are "ns", "us" (or "µs"), "ms", "s", "m", "h". | |||
There was a problem hiding this comment.
can you update etc/telegraf.conf with this comment as well?
- Check and return error from NewBatchPoints to prevent runtime panic if user provides an unparsable precision time unit in config. - Provide correct sample config precision examples. - Update etc/telegraf.conf precision comment.
|
looks good, thanks @netixen! 👍 |
geodimm
pushed a commit
to miketonks/telegraf
that referenced
this pull request
Mar 10, 2016
- Check and return error from NewBatchPoints to prevent runtime panic if user provides an unparsable precision time unit in config. - Provide correct sample config precision examples. - Update etc/telegraf.conf precision comment. closes influxdata#715
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
user provides an unparsable precision time unit in config.