Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs for how to handle errors in check-deps script #7243

Merged
merged 1 commit into from
Mar 27, 2020
Merged

Add docs for how to handle errors in check-deps script #7243

merged 1 commit into from
Mar 27, 2020

Conversation

danielnelson
Copy link
Contributor

This scripts output was confusing, this change adds some directions for how to handle errors.

Example output:

$ ./scripts/check-deps.sh
--- /tmp/tmp.NnRf7xH9bB/LICENSE_OF_DEPENDENCIES.md      2020-03-27 11:45:01.273020284 -0700
+++ /tmp/tmp.NnRf7xH9bB/HEAD    2020-03-27 11:45:01.272020301 -0700
@@ -67 +66,0 @@
-github.com/gorilla/context

The docs/LICENSE_OF_DEPENDENCIES.md file does not contain the expected entries.

Lines prefixed with '+' should be added to LICENSE_OF_DEPENDENCIES.md and '-'
lines should be removed.

Include a link to the appropriate licenses for any additions.

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@danielnelson danielnelson added this to the 1.15.0 milestone Mar 27, 2020
@danielnelson danielnelson requested a review from ssoroka March 27, 2020 18:50
@danielnelson danielnelson mentioned this pull request Mar 27, 2020
Closed
@danielnelson danielnelson merged commit 608e818 into master Mar 27, 2020
@danielnelson danielnelson deleted the check-deps-docs branch March 27, 2020 22:39
athoune pushed a commit to bearstech/telegraf that referenced this pull request Apr 17, 2020
@danielnelson
Add docs for how to handle errors in check-deps script (influxdata#7243)
6508808
veorlo pushed a commit to GlobalNOC/telegraf that referenced this pull request May 4, 2020
@danielnelson
Add docs for how to handle errors in check-deps script (influxdata#7243)
c66442c
HarshitOnGitHub pushed a commit to HarshitOnGitHub/telegraf that referenced this pull request May 8, 2020
@danielnelson @HarshitOnGitHub
Add docs for how to handle errors in check-deps script (influxdata#7243)
d28197f
idohalevi pushed a commit to idohalevi/telegraf that referenced this pull request Sep 29, 2020
@danielnelson
Add docs for how to handle errors in check-deps script (influxdata#7243)
0210e6b
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
@danielnelson
Add docs for how to handle errors in check-deps script (influxdata#7243)
f4fdd27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssoroka ssoroka ssoroka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@danielnelson @ssoroka