-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[processors] Add integer support to processors.enum
#7483
Conversation
7f3fe4f
to
5e9a768
Compare
|
||
assertFieldValue(t, int64(5), "uint_value", fields) | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we test mapping this to a string? seems like a common use case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, I removed the existing tests and added table tests to cover it more exhaustively. :)
5e9a768
to
28bb685
Compare
28bb685
to
c3e060d
Compare
Fixes: #7364
Required for all PRs: