Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processors] Add integer support to processors.enum #7483

Merged
merged 1 commit into from
May 11, 2020

Conversation

HarshitOnGitHub
Copy link
Contributor

Fixes: #7364

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.


assertFieldValue(t, int64(5), "uint_value", fields)
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we test mapping this to a string? seems like a common use case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, I removed the existing tests and added table tests to cover it more exhaustively. :)

@ssoroka ssoroka requested a review from danielnelson May 11, 2020 16:28
@danielnelson danielnelson added this to the 1.15.0 milestone May 11, 2020
@danielnelson danielnelson added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label May 11, 2020
@danielnelson danielnelson merged commit 568cb8e into influxdata:master May 11, 2020
rhajek pushed a commit to bonitoo-io/telegraf that referenced this pull request Jul 13, 2020
idohalevi pushed a commit to idohalevi/telegraf that referenced this pull request Sep 29, 2020
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add integer support to processors.enum
3 participants