Fix numeric to bool conversion in converter #7579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A type switch case with multiple conditions causes the value to remain as interface which causes toBool to always return true for any numeric values.
danielnelson
pushed a commit
that referenced
this pull request
May 26, 2020
A type switch case with multiple conditions causes the value to remain as interface which causes toBool to always return true for any numeric values. (cherry picked from commit ad97b74)
jaecktec
pushed a commit
to jaecktec/telegraf
that referenced
this pull request
Jun 8, 2020
A type switch case with multiple conditions causes the value to remain as interface which causes toBool to always return true for any numeric values.
rhajek
pushed a commit
to bonitoo-io/telegraf
that referenced
this pull request
Jul 13, 2020
A type switch case with multiple conditions causes the value to remain as interface which causes toBool to always return true for any numeric values.
idohalevi
pushed a commit
to idohalevi/telegraf
that referenced
this pull request
Sep 29, 2020
A type switch case with multiple conditions causes the value to remain as interface which causes toBool to always return true for any numeric values.
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
A type switch case with multiple conditions causes the value to remain as interface which causes toBool to always return true for any numeric values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A type switch case with multiple conditions causes the value to remain as
interface which causes toBool to always return true for any numeric values. Looking at the code this doesn't seem to be the desired behavior.
This PR treats all non-zero values as true as it seem to have been the intention
of the original code. This is inconsistent compared to conversion from string which uses
strconv.ParseBool. However, making it consistent would probably break things as the unit tests have test cases for positive values that are greater than 1.Required for all PRs: