Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Updates #779

Merged
merged 6 commits into from
Mar 3, 2016
Merged

Build Updates #779

merged 6 commits into from
Mar 3, 2016

Conversation

rossmcdonald
Copy link
Contributor

Some major changes to the build.py build script, including:

  • breaking ARM platforms out as different architectures (fixes Build ARM pacakge (.deb / .rpm) #708)
  • improves debug output
  • removes pkgarch and goarm build arguments
  • moves nightly versioning to use a <version>~n<epoch> over <version>.n<epoch>
  • removes zip as a packaging target due to FPM's poor support of zip
  • merges most changes from the InfluxDB and Kapacitor build scripts (more information here)
  • added a permissions check to the post-install script (fixes "insecure permissions" error fron logrotate cron task #713)

@sparrc
Copy link
Contributor

sparrc commented Mar 2, 2016

looks good, thanks @rossmcdonald,

Just one thing: I'd rather that the tests here and in the Makefile not diverge. Telegraf requires some docker containers for the tests to run so I'm pretty sure running the tests from build.py will fail. Could we remove the run_tests function from here, or have it just execute make test?

@rossmcdonald
Copy link
Contributor Author

@sparrc Yes, absolutely. I left the tests function in this version since they are a part of the InfluxDB and Kapacitor build processes, but I can take them out if they're not useful to you.

I'm also going to be re-adding the zip package functionality that was removed. I didn't realize that had been modified to be a manual process (instead of using fpm), so I should have this ready by EOD today. I'll ping you once it's ready for merging.

@sparrc
Copy link
Contributor

sparrc commented Mar 2, 2016

oh, sorry about that, I removed using fpm because it was creating zips with temp directories inside them that I couldn't figure out how to remove

@rossmcdonald
Copy link
Contributor Author

No worries at all. I could never figure out how to fix the zip's from including the temp directories, so I just removed them from the InfluxDB and Kapacitor package targets to simplify things. I'll re-add that portion, though.

@rossmcdonald rossmcdonald changed the title WIP - Build Updates Build Updates Mar 2, 2016
@rossmcdonald
Copy link
Contributor Author

Added in another fix to the post-install script, removed the test functionality, and re-added the zip functionality, so this is ready to go.

@sparrc sparrc force-pushed the ross-build-updates branch from 9f8175d to 8ef3c58 Compare March 3, 2016 21:35
@sparrc sparrc force-pushed the ross-build-updates branch from 8ef3c58 to b4b1866 Compare March 3, 2016 21:37
@sparrc sparrc merged commit b4b1866 into master Mar 3, 2016
@sparrc sparrc deleted the ross-build-updates branch March 3, 2016 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"insecure permissions" error fron logrotate cron task Build ARM pacakge (.deb / .rpm)
2 participants