Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): show error when update notebook fail #7009

Open
wants to merge 2 commits into
base: OSS-2.7
Choose a base branch
from
Open

feat(ui): show error when update notebook fail #7009

wants to merge 2 commits into from

Conversation

NguyenHoangSon96
Copy link

@NguyenHoangSon96 NguyenHoangSon96 commented Feb 14, 2025 •
edited by bednar
Loading

Closes #6999

UI will show error notification when the auto-update notebook call fails:

Screenshot 2025-02-14 at 17 23 11

Checklist

Authors and Reviewer(s), please verify the following:

  • A PR description, regardless of the triviality of this change, that communicates the value of this PR
  • Well-formatted conventional commit messages that provide context into the change
  • Documentation updated or issue created (provide link to issue/PR)
  • Signed CLA (if not already signed)
  • Feature flagged, if applicable

@NguyenHoangSon96 NguyenHoangSon96 requested a review from a team as a code owner February 14, 2025 10:31
@NguyenHoangSon96 NguyenHoangSon96 linked an issue Feb 14, 2025 that may be closed by this pull request
[notebooks]: if the autosave api returns an error, the ui still shows that the notebook saved, when it didn't #6999
Open
@NguyenHoangSon96 NguyenHoangSon96 self-assigned this Feb 14, 2025
@bednar bednar removed their request for review February 18, 2025 09:20
bednar
bednar requested changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@bednar bednar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The source branch should be master; the OSS-2.7 branch is used for releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bednar bednar bednar requested changes

Assignees

@NguyenHoangSon96 NguyenHoangSon96

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[notebooks]: if the autosave api returns an error, the ui still shows that the notebook saved, when it didn't
2 participants
@NguyenHoangSon96 @bednar