Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #156

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Fix typos #156

merged 1 commit into from
Sep 20, 2024

Conversation

jayvdb
Copy link
Contributor

@jayvdb jayvdb commented Sep 9, 2024

Description

Fix typos

Checklist

  • Formatted code using cargo fmt --all
  • Linted code using clippy
    • with reqwest feature: cargo clippy --manifest-path influxdb/Cargo.toml --all-targets --no-default-features --features serde,derive,reqwest-client-rustls -- -D warnings
    • with surf feature: cargo clippy --manifest-path influxdb/Cargo.toml --all-targets --no-default-features --features serde,derive,hyper-client -- -D warnings
  • Updated README.md using cargo doc2readme -p influxdb --expand-macros
  • Reviewed the diff. Did you leave any print statements or unnecessary comments?
  • Any unfinished work that warrants a separate issue captured in an issue with a TODO code comment

Copy link
Collaborator

@msrd0 msrd0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@msrd0 msrd0 enabled auto-merge (squash) September 9, 2024 11:34
@Empty2k12
Copy link
Collaborator

This requires a min rustc bump to 1.70 from 1.65

@jayvdb
Copy link
Contributor Author

jayvdb commented Sep 19, 2024

I was able to get the existing MSRV of 1.65 working at #157

@jayvdb
Copy link
Contributor Author

jayvdb commented Sep 19, 2024

You can see this works at https://github.com/jayvdb/influxdb-rust/tree/fix-msrv

@msrd0
Copy link
Collaborator

msrd0 commented Sep 20, 2024

None of the CI failures were caused by this PR. I believe they should be fixed, but I don't believe this PR should be blocked on it.

@msrd0 msrd0 disabled auto-merge September 20, 2024 08:06
@msrd0 msrd0 merged commit 5eecd0b into influxdb-rs:main Sep 20, 2024
21 of 24 checks passed
@jayvdb jayvdb deleted the typos branch December 13, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants