DEVOPS-30643: adds pgbouncer config to set the role before running SQL commands. #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
leandrorichardtoledo
commented
Jan 14, 2025
leandrorichardtoledo
commented
- This adds the server_reset_query configuration to pgbouncer.ini file to allow the queries to be executed with the role (spire-user) and not the user (spire-user_a);
drewwells
reviewed
Jan 14, 2025
dbproxy/pgbouncer/config.go
Outdated
| @@ -156,6 +96,9 @@ func parseURI(c *PGBouncerConfig, dsn string) error { | |||
| return fmt.Errorf("invalid_scheme: %s", u.Scheme) | |||
| } | |||
|
|
|||
| // Remove the _<a|b> suffix from the username. | |||
| c.RoleName = strings.Split(u.User.Username(), "_")[0] | |||
There was a problem hiding this comment.
Can we be more explicit here and pass in the exact role name ?
We don't prevent developers from putting _ in their username and then this parsing would fail.
There was a problem hiding this comment.
Pushed the change.
I ran the test I described in the ticket DEVOPS-30643; |
drewwells
reviewed
Jan 14, 2025
drewwells
approved these changes
Jan 14, 2025
Co-authored-by: Drew Wells <dwells@infoblox.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.