-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TK-65403 disable custom rest backend #48
Conversation
- custom rest does not register any resource verbs kubernetes-sigs/apiserver-builder-alpha#551 - template etcd variables - use temp dir by default - test example apiserver in PR build
0a97309
to
a2abc8a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could run your demo around this point of the e2e test:
konk/.github/workflows/pr.yaml
Line 69 in a2abc8a
kubectl exec -it $POD_NAME -- kubectl get crd appconfigs.stable.example.com websites.extensions.example.com |
2d83516
to
c9b5a0d
Compare
c9b5a0d
to
785388b
Compare
Added a PR step that verified contact CR can be created. The helm chart exists --wait without the API Service actually being up. This is disappointing. The until retries will ensure actions can be performed. |
@@ -97,7 +97,7 @@ tolerations: [] | |||
affinity: {} | |||
|
|||
apiserver: | |||
create: false | |||
create: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This creates the APIServer outside of konk, so what's the point? We want to prove it works inside konk.
TK-65403 disable custom rest backend
DEMO