Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TK-65403 disable custom rest backend #48

Merged
merged 4 commits into from
Oct 26, 2020
Merged

TK-65403 disable custom rest backend #48

merged 4 commits into from
Oct 26, 2020

Conversation

drewwells
Copy link
Contributor

@drewwells drewwells commented Oct 25, 2020

TK-65403 disable custom rest backend

- custom rest does not register any resource verbs kubernetes-sigs/apiserver-builder-alpha#551
- template etcd variables
- use temp dir by default
- test example apiserver in PR build

DEMO

k apply -f sample/contact.yaml                                  
contact.example.infoblox.com/contact-example created
k get contact                                                   
NAME              CREATED AT
contact-example   2020-10-25T03:35:23Z

- custom rest does not register any resource verbs kubernetes-sigs/apiserver-builder-alpha#551
- template etcd variables
- use temp dir by default
- test example apiserver in PR build
Copy link
Contributor

@kd7lxl kd7lxl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could run your demo around this point of the e2e test:

kubectl exec -it $POD_NAME -- kubectl get crd appconfigs.stable.example.com websites.extensions.example.com

@drewwells
Copy link
Contributor Author

Added a PR step that verified contact CR can be created. The helm chart exists --wait without the API Service actually being up. This is disappointing. The until retries will ensure actions can be performed.

https://github.com/infobloxopen/konk/pull/48/checks

@drewwells drewwells merged commit db8e01b into main Oct 26, 2020
@drewwells drewwells deleted the feature/apiserver branch October 26, 2020 19:03
@@ -97,7 +97,7 @@ tolerations: []
affinity: {}

apiserver:
create: false
create: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This creates the APIServer outside of konk, so what's the point? We want to prove it works inside konk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants