Add infoblox_zone_delegated resource #217
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…implfy integrations with other providers that only list NS FQDNs
|
Thank you for creating this resource, this is amazing! |
|
Is there a blocker for merging this? |
achernevskii
reviewed
Nov 8, 2022
| Required: true, | ||
| Description: "The FQDN of the delegated zone.", | ||
| }, | ||
| "delegate_to": resourceNameServer(), |
There was a problem hiding this comment.
Why do you move delegate_to schema definition into a separate function? There's no complex initialization logic involved, and this function is used only here.
| extAttrs := make(map[string]interface{}) | ||
| if extAttrJSON != "" { | ||
| if err := json.Unmarshal([]byte(extAttrJSON), &extAttrs); err != nil { | ||
| return fmt.Errorf("cannot process 'ext_attrs' field: %s", err.Error()) |
There was a problem hiding this comment.
I think it's better to wrap the error:
Suggested change
| return fmt.Errorf("cannot process 'ext_attrs' field: %s", err.Error()) | |
| return fmt.Errorf("cannot process 'ext_attrs' field: %w", err) |
| delegatedFQDN, | ||
| nameServers) | ||
| if err != nil { | ||
| return fmt.Errorf("Error creating Zone Delegated: %s", err) |
There was a problem hiding this comment.
Suggested change
| return fmt.Errorf("Error creating Zone Delegated: %s", err) | |
| return fmt.Errorf("Error creating Zone Delegated: %w", err) |
| if err != nil { | ||
| zoneDelegatedObj, err = objMgr.GetZoneDelegated(d.Id()) | ||
| if err != nil { | ||
| return fmt.Errorf("Getting Zone Delegated failed: %s", err) |
There was a problem hiding this comment.
Suggested change
| return fmt.Errorf("Getting Zone Delegated failed: %s", err) | |
| return fmt.Errorf("Getting Zone Delegated failed: %w", err) |
| extAttrs := make(map[string]interface{}) | ||
| if extAttrJSON != "" { | ||
| if err := json.Unmarshal([]byte(extAttrJSON), &extAttrs); err != nil { | ||
| return fmt.Errorf("cannot process 'ext_attrs' field: %s", err.Error()) |
There was a problem hiding this comment.
Suggested change
| return fmt.Errorf("cannot process 'ext_attrs' field: %s", err.Error()) | |
| return fmt.Errorf("cannot process 'ext_attrs' field: %w", err) |
|
|
||
| zoneDelegatedUpdated, err := objMgr.UpdateZoneDelegated(d.Id(), nameServers) | ||
| if err != nil { | ||
| return fmt.Errorf("Updating of Zone Delegated failed : %s", err.Error()) |
There was a problem hiding this comment.
Suggested change
| return fmt.Errorf("Updating of Zone Delegated failed : %s", err.Error()) | |
| return fmt.Errorf("Updating of Zone Delegated failed : %w", err) |
| extAttrs := make(map[string]interface{}) | ||
| if extAttrJSON != "" { | ||
| if err := json.Unmarshal([]byte(extAttrJSON), &extAttrs); err != nil { | ||
| return fmt.Errorf("cannot process 'ext_attrs' field: %s", err.Error()) |
There was a problem hiding this comment.
Suggested change
| return fmt.Errorf("cannot process 'ext_attrs' field: %s", err.Error()) | |
| return fmt.Errorf("cannot process 'ext_attrs' field: %w", err) |
|
|
||
| _, err := objMgr.DeleteZoneDelegated(d.Id()) | ||
| if err != nil { | ||
| return fmt.Errorf("Deletion of Zone Delegated failed : %s", err) |
There was a problem hiding this comment.
Suggested change
| return fmt.Errorf("Deletion of Zone Delegated failed : %s", err) | |
| return fmt.Errorf("Deletion of Zone Delegated failed : %w", err) |
doughepi
pushed a commit
to doughepi/terraform-provider-infoblox
that referenced
this pull request
May 16, 2024
Aish-sp
pushed a commit
to Aish-sp/terraform-provider-infoblox
that referenced
this pull request
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new resource to support Zone Delegation
Features:
Caveats: