-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7228 - Fix npm commands #7229
7228 - Fix npm commands #7229
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on a HP running Windows 10 all good.
@awbuboltz your right the ids-website should be cleared. I made an update. But i think this command is almost not really needed but just in case. |
Changes make sense to me and it now works on Windows. |
cool - considering this approved but a wierd thing with the tests happened. Cant be related so retrying |
…terprise into 7228-fix-windows
Explain the details for making this change. What existing problem does the pull request solve?
The clean commands did not work due to isaacs/rimraf#249
Related github/jira issue (required):
Fixes #7228
Steps necessary to review your pull request (required):
npm i
from beforeIncluded in this Pull Request: