Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log packet type and payload on success #1013

Closed
5 tasks
Tracked by #1538
ebuchman opened this issue May 28, 2021 · 0 comments
Closed
5 tasks
Tracked by #1538

Log packet type and payload on success #1013

ebuchman opened this issue May 28, 2021 · 0 comments
Labels
A: low-priority Admin: low priority / non urgent issue, expect longer wait time for PR reviews I: logic Internal: related to the relaying logic O: usability Objective: cause to improve the user experience (UX) and ease using the product
Milestone

Comments

@ebuchman
Copy link
Member

Crate

relayer-cli

Summary

Include the packet type and the payload in the hermes log output to facilitate debugging. Eg. for ICS20 packets, operators can see the sender, receiver, and amount

Problem Definition

On success Hermes logs look something like:

May 28 08:27:51.216 DEBUG ibc_relayer::foreign_client: [cosmoshub-4 -> informal-testnet-1:07-tendermint-1] MsgUpdateAnyClient for target height 4-6378999 and trusted height 4-6356135
May 28 08:27:51.216  INFO ibc_relayer::link: [cosmoshub-4 -> informal-testnet-1] assembled batch of 2 message(s)
May 28 08:27:54.752  INFO ibc_relayer::link: [cosmoshub-4 -> informal-testnet-1] result events:
        UpdateClientEv(h: 1-75185, cs_h: 07-tendermint-1(4-6378999))
        AcknowledgePacketEv(h:1-75185, seq:52, path:channel-0/transfer->channel-124/transfer, toh:4-6379144, tos:Timestamp(NoTimestamp)))


May 28 08:27:54.752  INFO ibc_relayer::link: [cosmoshub-4 -> informal-testnet-1] success

Might be nice if there was a bit more data on the actual packet that got relayed.

This was something that came up a few times during my demo that it would have been nice to see which address the packet was relayed for.

Obviously not a high priority, just a nice to have.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@adizere adizere added this to the 11.2021 milestone Aug 3, 2021
@adizere adizere added I: logic Internal: related to the relaying logic O: usability Objective: cause to improve the user experience (UX) and ease using the product labels Aug 3, 2021
@adizere adizere modified the milestones: 11.2021, 12.2021, v0.8.3 Nov 2, 2021
@adizere adizere added the A: low-priority Admin: low priority / non urgent issue, expect longer wait time for PR reviews label Jan 18, 2022
@adizere adizere modified the milestones: v0.11.0, v0.11.1 Jan 25, 2022
@romac romac modified the milestones: v0.11.1, v0.12.0 Feb 2, 2022
@adizere adizere modified the milestones: v0.12.0, v0.12.2 Feb 14, 2022
@adizere adizere modified the milestones: v0.14.0, v1.1 Mar 29, 2022
@adizere adizere modified the milestones: v1.1, v2 Jun 29, 2022
@adizere adizere closed this as not planned Won't fix, can't repro, duplicate, stale Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: low-priority Admin: low priority / non urgent issue, expect longer wait time for PR reviews I: logic Internal: related to the relaying logic O: usability Objective: cause to improve the user experience (UX) and ease using the product
Projects
No open projects
Status: Closed
Development

Successfully merging a pull request may close this issue.

5 participants