Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More domain-type relevant details in Hermes logs #1799

Closed
wants to merge 5 commits into from
Closed

Conversation

adizere
Copy link
Member

@adizere adizere commented Jan 24, 2022

Closes: #1013

Description

  • fix consistent tracking id tag: sometimes we use id=xxx and other times we say odata=xxx
    • example:
    • 1069 Jan 20 17:11:51 Imperator-Relayer hermes[1854166]: 2022-01-20T17:11:51.023699Z DEBUG ThreadId(79) packet_cmd{src_chain=osmosis-1 src_port=transfer src_channel=channel-82 dst_chain=panacea-3}:clear{f=false}:generate{id=EYIMu5yhL8}: /ibc.core.channel.v1.MsgAcknowledgement from WriteAcknowledgementEv(WriteAcknowledgement - h:1-2876532, seq:2558, path:channel-1/transfer->channel-82/transfer, toh:1-2876499, tos:Timestamp(NoTimestamp)))
      1070 Jan 20 17:11:51 Imperator-Relayer hermes[1854166]: 2022-01-20T17:11:51.024037Z DEBUG ThreadId(79) packet_cmd{src_chain=osmosis-1 src_port=transfer src_channel=channel-82 dst_chain=panacea-3}:clear{f=false}:schedule{odata=EYIMu5yhL8 ->Destination @1-2876532; len=128}: connecti on delay is zero: client update message will be prepended later


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

Copy link
Contributor

@mzabaluev mzabaluev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, apart from the somewhat monolithic Display impls that are used to log packet data.

@adizere adizere marked this pull request as ready for review January 25, 2022 13:59
@adizere adizere marked this pull request as draft January 25, 2022 14:49
@adizere
Copy link
Member Author

adizere commented Jan 25, 2022

Let's delay this work until next release (https://github.com/informalsystems/ibc-rs/milestone/28) since the original issue #1013 is not as straightforward as I thought it was.

@mzabaluev mzabaluev self-requested a review January 26, 2022 12:20
@adizere
Copy link
Member Author

adizere commented Mar 28, 2022

Closing until we reprioritize this again.

@adizere adizere closed this Mar 28, 2022
@romac romac deleted the log_lifecycle branch November 22, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log packet type and payload on success
2 participants