Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client identifier sorting optimization #1024

Closed
5 tasks done
adizere opened this issue Jun 1, 2021 · 0 comments · Fixed by #1432
Closed
5 tasks done

Client identifier sorting optimization #1024

adizere opened this issue Jun 1, 2021 · 0 comments · Fixed by #1432
Assignees
@adizere
Labels
A: good-first-issue Admin: good for newcomers O: new-feature Objective: cause to add a new feature or support
Milestone
10.2021

Comments

@adizere
Copy link
Member

adizere commented Jun 1, 2021 •
edited by romac
Loading

Crate

ibc-relayer mostly

Summary

Two nitpicks:

a) We should probably use sort_by_cached_key here to avoid recomputing the suffix on every comparison
b) This could be rewritten in a slightly simpler way using sort_by_{cached_}key:

clients.sort_by_cached_key(|c| client_id_suffix(&c.client_id).unwrap_or(0))

Original comment

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@adizere adizere added O: new-feature Objective: cause to add a new feature or support A: good-first-issue Admin: good for newcomers labels Jun 1, 2021
@adizere adizere added this to the 07.2021 milestone Jun 1, 2021
@adizere adizere self-assigned this Jun 1, 2021
@adizere adizere modified the milestones: 07.2021, 09.2021 Jun 26, 2021
@adizere adizere modified the milestones: 09.2021, Backlog Sep 6, 2021
blewater added a commit to blewater/ibc-rs that referenced this issue Oct 6, 2021
@blewater
informalsystems#1024 Sort optimize client_id_suffix
1295fb4
@blewater blewater mentioned this issue Oct 6, 2021
Merged
5 tasks
blewater added a commit to blewater/ibc-rs that referenced this issue Oct 6, 2021
@blewater
informalsystems#1024 Optimize clients sorting by client_id_suffix
6f68b2a
blewater added a commit to blewater/ibc-rs that referenced this issue Oct 7, 2021
@blewater
informalsystems#1024 Unit test
b69e58f
romac added a commit that referenced this issue Oct 7, 2021
@blewater @romac
Replace a clients sort_by with sort_by_cached_key to avoid callin…
0f72f76 
…g `client_id_suffix()` repeatedly (#1432)

* #1024 Optimize clients sorting by client_id_suffix

* #1024 Unit test

* Formatting

Co-authored-by: Romain Ruetschi <romain@informal.systems>
@adizere adizere modified the milestones: Backlog, 10.2021 Oct 28, 2021
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this issue Sep 13, 2022
@blewater @romac
Replace a clients sort_by with sort_by_cached_key to avoid callin…
ea127f7 
…g `client_id_suffix()` repeatedly (informalsystems#1432)

* informalsystems#1024 Optimize clients sorting by client_id_suffix

* informalsystems#1024 Unit test

* Formatting

Co-authored-by: Romain Ruetschi <romain@informal.systems>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adizere adizere

Labels
A: good-first-issue Admin: good for newcomers O: new-feature Objective: cause to add a new feature or support
Projects
None yet
Milestone
10.2021
Development

Successfully merging a pull request may close this issue.

#1024 Sort optimize client_id_suffix blewater/ibc-rs
2 participants
@adizere @andynog