Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration reload #1117

Closed
9 tasks done
romac opened this issue Jun 22, 2021 · 0 comments · Fixed by #1123
Closed
9 tasks done

Configuration reload #1117

romac opened this issue Jun 22, 2021 · 0 comments · Fixed by #1123
Assignees
Labels
E: gravity External: related to Gravity DEX O: new-feature Objective: cause to add a new feature or support
Milestone

Comments

@romac
Copy link
Member

romac commented Jun 22, 2021

Crate

ibc-relayer, ibc-relayer-cli

Summary

Add ability for Hermes to reload the configuration from disk without restarting it.

Problem Definition

At the moment, for Hermes to pick any change to its configuration, operators need to stop and restart Hermes.

We want to provide a mechanism to trigger a reloading of Hermes configuration without having to restart it, eg. via a POSIX signal (typically SIGHUP).

Proposal

  • Add ability to parse the configuration from disk at runtime
  • Perform a diff from the currently loaded configuration and the new one
  • Spawn or shutdown the appropriate workers based on the configuration changes
  • Hook up the SIGHUP signal to trigger a config reload

Acceptance Criteria

The relayer reacts to a SIGHUP signal by reloading the configuration and spawning or shutting down the affected workers.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@romac romac added O: new-feature Objective: cause to add a new feature or support E: gravity External: related to Gravity DEX labels Jun 22, 2021
@romac romac added this to the 06.2021 milestone Jun 22, 2021
@romac romac self-assigned this Jun 22, 2021
@romac romac mentioned this issue Jun 23, 2021
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E: gravity External: related to Gravity DEX O: new-feature Objective: cause to add a new feature or support
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants