Packet worker is spawned on channel ack and confirm events

[romac]

Why do we spawn the packet workers on OpenAckChannel and OpenConfirmChannel events? The following sequences result in different worker set for hermes:

• hermes start then hermes create channel...
• hermes create channel... then hermes start

Code is here https://github.com/informalsystems/ibc-rs/blob/1481a16ee077f6708e3f2ce1866f8e90340fdf46/relayer/src/supervisor.rs#L403-L405
and here
https://github.com/informalsystems/ibc-rs/blob/1481a16ee077f6708e3f2ce1866f8e90340fdf46/relayer/src/supervisor.rs#L419-L421

Originally posted by @ancazamfir in #1931 (comment)

[romac]

May be related to #1978.

[romac]

As far as @ancazamfir and I can tell, this was introduced in the config reload PR (#1117) in order to check for pending packets on channels opened after adding a chain to the config and triggering a config reload.

This code is not needed anymore, and should be removed, especially since it does not honor the packet filter.

[romac]

May be related to #1978.

Does not seem to help with that issue: #1977 (comment)