-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the relayer CLI and library top-level folders #180
Comments
I like the suggested re-org of the folders. More inline with tendermint-rs that has the crates as top-level. But we should just to plan it accordingly since this is a major refactoring just need to bear in mind what the best workflow for this concerning merges and PRs. The work effort here is not big but has to be the least disruptive as possible to parallel development. Maybe integrate this just before the next release? |
I wouldn't wait until the next release, since we didn't release this library yet, as far as I know. The sweet spot is when there is no ongoing soon-to-be-merged work in the repo. I'm aware of Andy's work on connections that is soon-to-be-merged, but everything else we work on right now seems fairly experimental and higher-level. And most importantly, full of new files. My proposal is that we do this right after Andy's client query work is done, to try to minimize the pain for any other ongoing work. |
Ok, this is happening after Andy's PR. Here's the proposed naming: modules I suggest cosmos/ibc-rs#125 use the |
Summary
It's a bit confusing that the
relayer
and themodules
are top-level libraries and althoughmodules
is a crate in its own right, therelayer
has acli
subfolder and arelay
subfolder which are their own crates.Also cosmos/ibc-rs#125 the name of the modules crate is weird.
Proposal
All crates should be top-level folders in the repo. Namely:
modules
relayer-cli
relayer
(ibc-proto as of cosmos/ibc-proto-rs#23 )
Alternatively (and in line with cosmos/ibc-proto-rs#23) all should have the
ibc-
prefix. That would make the naming for the crates (#167) also clear.For Admin Use
The text was updated successfully, but these errors were encountered: