Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved relayer/cli to relayer-cli, relayer/relay to relayer #183

Merged
merged 3 commits into from
Jul 29, 2020

Conversation

greg-szabo
Copy link
Member

@greg-szabo greg-szabo commented Jul 29, 2020

Closes: #180

Description

Steps made in the change:

  • Moved the relayer/cli folder to relayer-cli
  • Moved the relayer/relay folder to relayer
  • Updated Cargo.toml to point to relayer-cli and relayer respectively
  • Updated relayer-cli/Cargo.toml to point the relayer dependency to ../relayer instead of ../relay

I wanted to minimize any changes because moving such a big amount of files is hard to review.

  • After a bit of contemplating, I've updated the CHANGELOG file too. We should get in the habit of it even when a lot of files are involved.

For contributor use:

  • Unit tests written
  • Added test to CI if applicable
  • Updated CHANGELOG_PENDING.md
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments
  • Re-reviewed Files changed in the Github PR explorer

@greg-szabo
Copy link
Member Author

Give me a few minutes to fix all the other paths I didn't think about.

@andynog
Copy link
Contributor

andynog commented Jul 29, 2020

The changes looks good to me. Just one question, should we call the modules folder 'ibc-module' or something like this ?

Also, should we take this repo refactoring opportunity to start adding information to this issue ?

@greg-szabo
Copy link
Member Author

I wouldn't put the ibc- prefix in front of any of the folders. It's the IBC repository, so we should assume that everything is ibc-related.

The crate.io crates should have the ibc- prefix, but we can discuss that in its own issue. (#142 and cosmos/ibc-rs#125)

@ebuchman ebuchman merged commit 9c733d7 into master Jul 29, 2020
@ebuchman ebuchman deleted the greg/dir-refactor branch July 29, 2020 23:40
@adizere adizere mentioned this pull request Jul 31, 2020
4 tasks
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
…ystems#183)

* Moved relayer/cli to relayer-cli, relayer/relay to relayer

* Updated CHANGELOG

* Changed paths in documentation and CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the relayer CLI and library top-level folders
3 participants