Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misleading error message in misbehavior detection task #2031

Closed
1 task
Tracked by #1538
adizere opened this issue Mar 29, 2022 · 0 comments · Fixed by #2156
Closed
1 task
Tracked by #1538

Misleading error message in misbehavior detection task #2031

adizere opened this issue Mar 29, 2022 · 0 comments · Fixed by #2156
Assignees
@adizere
Labels
O: code-hygiene Objective: cause to improve code hygiene O: usability Objective: cause to improve the user experience (UX) and ease using the product
Milestone
v0.15.0

Comments

@adizere
Copy link
Member

adizere commented Mar 29, 2022 •
edited
Loading

Problem

An operator reported this error message being confusing:

WARN ThreadId(684) DetectMisbehaviorWorker{client=07-tendermint-22 src_chain=injective-1 dst_chain=secret-4}: [injective-1 -> secret-4:07-tendermint-22] misbehaviour checking result: error raised while checking for misbehaviour evidence: failed to check misbehaviour for 07-tendermint-22 at consensus height 1-8804649: light client error for RPC address injective-1: trusted state outside of trusting period

The immediate intuition of everyone was that this client must be expired, and the operator simply stopped relaying on that path consequently.

This log concerns an IBC client hosted on secret-4 targeting chain injective-1.
There is traffic on the channel/client, eg
https://www.mintscan.io/secret/txs/DCF6C78F76604426A6A491599D742817EAA9B45A46887386FDC05F1DA62950EF

The client is not expired, it's just impossible for Hermes to verify the header for height 1-8804649 of this client. We should adjust that log message in Hermes because it is misleading.

Acceptance criteria

  • Modify the misbehavior task error-level log message to make it clear that this message is not about client being expired
@adizere adizere added the O: code-hygiene Objective: cause to improve code hygiene label Mar 29, 2022
@adizere adizere added this to the v0.15.0 milestone Mar 29, 2022
@adizere adizere added P-medium O: usability Objective: cause to improve the user experience (UX) and ease using the product labels Mar 29, 2022
@adizere adizere mentioned this issue Mar 29, 2022
Closed
16 tasks
@adizere adizere self-assigned this Apr 16, 2022
adizere added a commit that referenced this issue Apr 16, 2022
@adizere
Tentative fix for #2031.
b852c7e
@adizere adizere mentioned this issue Apr 28, 2022
Merged
6 tasks
adizere added a commit that referenced this issue May 9, 2022
@adizere @soareschen @romac
Fix misleading error message in misbehavior detection task (#2156)
817aaa3 
* Tentative fix for #2031.

* Added span to light_client method. Removed FIXME.

* changelog

* Add error method is_trusted_state_outside_trusting_period_error

* Fix clippy warnings

* Removed stale TODO

* Adapted to Anca's suggestion

Co-authored-by: Soares Chen <soares.chen@maybevoid.com>
Co-authored-by: Romain Ruetschi <romain@informal.systems>
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this issue Sep 13, 2022
@adizere @soareschen @romac
Fix misleading error message in misbehavior detection task (informals…
983d32e 
…ystems#2156)

* Tentative fix for informalsystems#2031.

* Added span to light_client method. Removed FIXME.

* changelog

* Add error method is_trusted_state_outside_trusting_period_error

* Fix clippy warnings

* Removed stale TODO

* Adapted to Anca's suggestion

Co-authored-by: Soares Chen <soares.chen@maybevoid.com>
Co-authored-by: Romain Ruetschi <romain@informal.systems>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adizere adizere

Labels
O: code-hygiene Objective: cause to improve code hygiene O: usability Objective: cause to improve the user experience (UX) and ease using the product
Projects
No open projects
IBC-rs: the road to v1
Status: Closed
Milestone
v0.15.0
Development

Successfully merging a pull request may close this issue.

Fix misleading error message in misbehavior detection task informalsystems/hermes
1 participant
@adizere