Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inconsistency between query packet pending and query packet unreceived-acks/unreceived-packets #2379

Closed
5 tasks
Tracked by #2355
romac opened this issue Jul 6, 2022 · 0 comments · Fixed by #2355
Closed
5 tasks
Tracked by #2355

Fix inconsistency between query packet pending and query packet unreceived-acks/unreceived-packets #2379

romac opened this issue Jul 6, 2022 · 0 comments · Fixed by #2355
Assignees
@romac
Milestone
v1.0.0

Comments

@romac
Copy link
Member

romac commented Jul 6, 2022

Problem Definition

From #2265 (comment)

We have an inconsistency between query packet pending and query packet unreceived-acks/unreceived-packets
- We should stick to one adjective consistency: either pending or unreceived
- Additionally, it's not accurate to use the word "acks" in unreceived-acks because "acks" are a type of packets; so when we say unreceived-packets that should actually include acks -> we should consider renaming unreceived-packets into unreceived-send or something similar to make the clear distinction between sends and acks.

Proposal

  • Rename query packet unreceived-packets to query packet pending-sends
  • Rename query packet unreceived-acks to query packet pending-acks

Acceptance Criteria

The commands have been renamed as proposed above.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@romac romac added this to the v1.0.0 milestone Jul 6, 2022
@romac romac self-assigned this Jul 6, 2022
@romac romac moved this to Backlog in IBC-rs: the road to v1 Jul 6, 2022
@romac romac mentioned this issue Jul 6, 2022
Merged
6 tasks
romac added a commit that referenced this issue Jul 6, 2022
@romac
Add changelog entry for #2379
512657b
romac added a commit that referenced this issue Jul 7, 2022
@romac @hu55a1n1 @soareschen
Release Hermes v1.0.0 (#2355)
b80bcea 
* Update top-level modules doc comments in ibc-relayer-cli

* Update lockfile

* Improve `spawn_chain_runtime_*` functions doc comments

* Rename `query unreceived-packets` to `query pending-sends` and `query unreceived-acks` to `query pending-acks`

* Fix misfiled changelog entry and add `ibc-telemetry` component

* Add changelog entry for #2379

* Bump `ibc-proto` version to 0.19.0

* Bump crates to v0.16.0

* Bump Hermes to v1.0.0-rc.0

* Update lockfile

* Release changelog

* Add UPGRADING document

* Update changelog

* Manually restructure the CHANGELOG

* Apply suggestions from review

Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com>
Co-authored-by: Soares Chen <soares.chen@maybevoid.com>

* Change unreceived to pending in the guide

* Fix line numbers in link

* Fix header in changelog

Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com>
Co-authored-by: Soares Chen <soares.chen@maybevoid.com>
Repository owner moved this from Backlog to Closed in IBC-rs: the road to v1 Jul 7, 2022
hu55a1n1 added a commit to hu55a1n1/hermes that referenced this issue Sep 13, 2022
@romac @hu55a1n1 @soareschen
Release Hermes v1.0.0 (informalsystems#2355)
4b8883a 
* Update top-level modules doc comments in ibc-relayer-cli

* Update lockfile

* Improve `spawn_chain_runtime_*` functions doc comments

* Rename `query unreceived-packets` to `query pending-sends` and `query unreceived-acks` to `query pending-acks`

* Fix misfiled changelog entry and add `ibc-telemetry` component

* Add changelog entry for informalsystems#2379

* Bump `ibc-proto` version to 0.19.0

* Bump crates to v0.16.0

* Bump Hermes to v1.0.0-rc.0

* Update lockfile

* Release changelog

* Add UPGRADING document

* Update changelog

* Manually restructure the CHANGELOG

* Apply suggestions from review

Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com>
Co-authored-by: Soares Chen <soares.chen@maybevoid.com>

* Change unreceived to pending in the guide

* Fix line numbers in link

* Fix header in changelog

Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com>
Co-authored-by: Soares Chen <soares.chen@maybevoid.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@romac romac

Labels
None yet
Projects
No open projects
IBC-rs: the road to v1
Status: Closed
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

Release Hermes v1.0.0-rc.0 informalsystems/hermes
1 participant
@romac