Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate proto-compiler logic into main.rs #241

Closed
greg-szabo opened this issue Jul 14, 2020 · 2 comments · Fixed by #317
Closed

Consolidate proto-compiler logic into main.rs #241

greg-szabo opened this issue Jul 14, 2020 · 2 comments · Fixed by #317

Comments

@greg-szabo
Copy link
Member

No description provided.

@romac romac transferred this issue from informalsystems/ibc-proto Sep 18, 2020
@romac romac changed the title Move the build.rs stuff to main.rs in ibc-prost-compiler ibc-proto: Move the build.rs stuff to main.rs in ibc-prost-compiler Sep 18, 2020
@ancazamfir
Copy link
Collaborator

@greg-szabo
No, we can’t fully move it, Prost is build-based, not runtime.

@romac romac mentioned this issue Oct 16, 2020
Merged
6 tasks
@romac
Copy link
Member

romac commented Oct 16, 2020

This is actually possible, see #317.

@romac romac reopened this Oct 16, 2020
@romac romac changed the title ibc-proto: Move the build.rs stuff to main.rs in ibc-prost-compiler Consolidate proto-compiler logic into main.rs Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Consolidate proto-compiler logic into main.rs informalsystems/hermes
3 participants
@romac @ancazamfir @greg-szabo