Consolidate proto-compiler logic into main.rs #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
Would it be possible to add a README.md in |
Done.
Yes! |
ancazamfir
approved these changes
Oct 16, 2020
This reverts commit 22d2e4b.
greg-szabo
approved these changes
Oct 16, 2020
| pub(crate) fn main() { | ||
| let ibc_proto_path = "../proto/src/prost"; | ||
| fn main() { | ||
| let root = PathBuf::from(env!("CARGO_MANIFEST_DIR")); |
| println!("[info ] Cloning cosmos/cosmos-sdk repository..."); | ||
|
|
||
| let url = "https://github.com/cosmos/cosmos-sdk"; | ||
| Repository::clone(url, &sdk_dir).unwrap(); |
There was a problem hiding this comment.
I'll have a more robust solution to this in the tendermint-proto crate. Later, for a next update.
Co-authored-by: Greg Szabo <16846635+greg-szabo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #241
Description
This PR consolidates the proto-compiler crate into a single binary.
Cloning the SDK, compiling the .proto files to Rust, and copying them to the appropriate location now only happen at runtime, whereas it was previously split between build time (via
build.rs) and runtime (viamain.rs).This should let us improve on the UX of the proto-compiler binary in the future, eg. by introducing a proper CLI, etc.
For contributor use:
docs/) and code commentsFiles changedin the Github PR explorer