Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICS31 Cross-Chain Queries integration tests #2967

Closed
6 tasks
Tracked by #2970
ljoss17 opened this issue Dec 20, 2022 · 0 comments · Fixed by #3061
Closed
6 tasks
Tracked by #2970

ICS31 Cross-Chain Queries integration tests #2967

ljoss17 opened this issue Dec 20, 2022 · 0 comments · Fixed by #3061
Assignees
Labels
O: ics31-cross-chain-queries Objective: ICS 031, Cross-Chain Queries O: tests Objective: Test more aspect of the relayer

Comments

@ljoss17
Copy link
Contributor

ljoss17 commented Dec 20, 2022

Summary

The ICS31 implemented in #2915 is currently only tested manually with https://github.com/informalsystems/hermes/wiki/Testing-examples#ics31-cross-chain-queries.

There might also be an compatibility issue due to proto definitions. The suspicion comes from the fact that Stride and Persistence use different proto files, https://github.com/Stride-Labs/stride/blob/main/proto/stride/interchainquery/v1/messages.proto and https://github.com/persistenceOne/persistence-sdk/blob/master/proto/persistence/interchainquery/v1beta1/messages.proto.
The integration tests should be able to easily confirm or discard this suspicion.

Problem Definition

In order to test ICS31 with Stride, an admin account is required: https://github.com/Stride-Labs/stride/blob/main/utils/admins.go
So the two solutions to my knowledge are:

  1. Adding the necessary Admin account and recompile Stride binary
  2. Using Stride's dockernet (which is the solution used in the Wiki)

In order to have some running integration tests in Hermes, a solution which allows to trigger Cross-Chain Queries without modifying Stride's binary or using the dockernet is required.

Proposal

Adding integration tests for ICS31

Acceptance Criteria

  • Successful integration tests for ICS31

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@ljoss17 ljoss17 added the O: tests Objective: Test more aspect of the relayer label Dec 20, 2022
@seanchen1991 seanchen1991 added the O: ics31-cross-chain-queries Objective: ICS 031, Cross-Chain Queries label Jan 10, 2023
@seanchen1991 seanchen1991 added this to the v1.3 milestone Jan 10, 2023
@seanchen1991 seanchen1991 removed this from the v1.3 milestone Jan 31, 2023
@ljoss17 ljoss17 mentioned this issue Feb 6, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O: ics31-cross-chain-queries Objective: ICS 031, Cross-Chain Queries O: tests Objective: Test more aspect of the relayer
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants