-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cross-Chain Queries (ICS-031) refactoring #2915
Merged
ljoss17
merged 43 commits into
informalsystems:master
from
validance:refactoring/ics-031-crosschain-queries
Dec 20, 2022
Merged
Cross-Chain Queries (ICS-031) refactoring #2915
ljoss17
merged 43 commits into
informalsystems:master
from
validance:refactoring/ics-031-crosschain-queries
Dec 20, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
ljoss17
reviewed
Dec 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! I left a few initial comments, and I will continue to review this.
…alidance/ibc-rs into refactoring/ics-031-crosschain-queries feat: merge updated master
ljoss17
reviewed
Dec 14, 2022
…-crosschain-queries
…-crosschain-queries
ljoss17
reviewed
Dec 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small nits, but great work!!
6 tasks
ljoss17
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #2915
Complementary pr for #2723
After I created the earlier one, there were pretty a lot of changes such as refactoring for crates such as cosmos/ibc-proto-rs and relayer_types.
For better readability and easy code management, opened another one synced up to the latest master branch.
Merkle proof of query result via abci_query is included in this version which is the main difference between the earlier one but pre-requisite is needed because of the mechanism of stride binary like adding specific address to admin list, so e2e test using hermes' test framework is not included currently.
Instead, I uploaded some scripts for local test:
https://github.com/validance/stride-gaia-local
Following README.md might enough to understand how the kv query works!
Thank you
PR author checklist:
unclog
.docs/
).Reviewer checklist:
Files changed
in the GitHub PR explorer.