Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-Chain Queries (ICS-031) refactoring #2915

Merged

Conversation

SangyunOck
Copy link
Contributor

@SangyunOck SangyunOck commented Dec 2, 2022

Description

Closes: #2915
Complementary pr for #2723

After I created the earlier one, there were pretty a lot of changes such as refactoring for crates such as cosmos/ibc-proto-rs and relayer_types.

For better readability and easy code management, opened another one synced up to the latest master branch.

Merkle proof of query result via abci_query is included in this version which is the main difference between the earlier one but pre-requisite is needed because of the mechanism of stride binary like adding specific address to admin list, so e2e test using hermes' test framework is not included currently.

Instead, I uploaded some scripts for local test:
https://github.com/validance/stride-gaia-local

Following README.md might enough to understand how the kv query works!

Thank you


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@SangyunOck SangyunOck mentioned this pull request Dec 2, 2022
7 tasks
Copy link
Contributor

@ljoss17 ljoss17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! I left a few initial comments, and I will continue to review this.

crates/relayer-types/src/applications/ics31_icq/events.rs Outdated Show resolved Hide resolved
crates/relayer-types/src/applications/ics31_icq/events.rs Outdated Show resolved Hide resolved
crates/relayer-types/src/applications/ics31_icq/events.rs Outdated Show resolved Hide resolved
crates/relayer/src/chain/handle/counting.rs Show resolved Hide resolved
crates/relayer/src/object.rs Outdated Show resolved Hide resolved
crates/relayer/src/object.rs Outdated Show resolved Hide resolved
crates/relayer/src/worker/cross_chain_query.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@ljoss17 ljoss17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small nits, but great work!!

crates/relayer/src/worker/cross_chain_query.rs Outdated Show resolved Hide resolved
crates/relayer-types/src/applications/ics31_icq/error.rs Outdated Show resolved Hide resolved
@ljoss17 ljoss17 merged commit bc09e84 into informalsystems:master Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants