Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event monitor emits error when test framework shuts down the chains #3120

Closed
5 tasks
romac opened this issue Feb 23, 2023 · 0 comments · Fixed by #3121
Closed
5 tasks

Event monitor emits error when test framework shuts down the chains #3120

romac opened this issue Feb 23, 2023 · 0 comments · Fixed by #3121
Assignees
Labels
A: bug Admin: something isn't working A: low-priority Admin: low priority / non urgent issue, expect longer wait time for PR reviews

Comments

@romac
Copy link
Member

romac commented Feb 23, 2023

Summary of Bug

When the test framework shuts down the chains, the event monitor emits the following error:

2023-02-23T09:11:20.974583Z  INFO ibc_test_framework::types::binary::chains: stopping chain handle ibc-2
2023-02-23T09:11:20.974917Z  INFO ibc_test_framework::types::binary::chains: stopping chain handle ibc-1
2023-02-23T09:11:20.979464Z ERROR event_monitor{chain=ibc-1}: ibc_relayer::event::monitor: failed to collect events:
   0: WebSocket driver failed
   1:
   1:    0: web socket error: failed to read from WebSocket connection
   1:    1: WebSocket protocol error: Connection reset without closing handshake

This was introduced in 3095.

It is not a correctness problem and it does not impact the test results, but it clutters the logs and should be handled better.

Version

1.3.0

Steps to Reproduce

Run the integration test suite and look for the error above

Acceptance Criteria

The event monitor shuts down gracefully and does not emit errors.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@romac romac added A: bug Admin: something isn't working A: low-priority Admin: low priority / non urgent issue, expect longer wait time for PR reviews labels Feb 23, 2023
@romac romac self-assigned this Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Admin: something isn't working A: low-priority Admin: low priority / non urgent issue, expect longer wait time for PR reviews
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant