Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure the event monitor is shut down cleanly #3121

Merged
merged 2 commits into from
Feb 27, 2023
Merged

Ensure the event monitor is shut down cleanly #3121

merged 2 commits into from
Feb 27, 2023

Conversation

romac
Copy link
Member

@romac romac commented Feb 23, 2023 •
edited
Loading

Closes: #3120

Description

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@romac romac changed the title Fix error emitted by event monitor on chain driver shutdown Ensure the event monitor is shut down cleanly Feb 24, 2023
@romac romac marked this pull request as ready for review February 24, 2023 14:52
@romac romac merged commit 1fec32e into master Feb 27, 2023
@romac romac deleted the romac/ws-shutdown-error branch February 27, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljoss17 ljoss17 ljoss17 approved these changes

@mzabaluev mzabaluev Awaiting requested review from mzabaluev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Event monitor emits error when test framework shuts down the chains
2 participants
@romac @ljoss17