Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ICA tests #3353

Closed
5 tasks
ljoss17 opened this issue May 22, 2023 · 0 comments · Fixed by #3415
Closed
5 tasks

Improve ICA tests #3353

ljoss17 opened this issue May 22, 2023 · 0 comments · Fixed by #3415
Assignees
@ljoss17
Labels
O: ics27-ica Objective: ICS 027, Interchain Accounts O: testability Objective: cause to provide more testing tools and extensions

Comments

@ljoss17
Copy link
Contributor

ljoss17 commented May 22, 2023

Proposal

Hermes v1.4.1 is using interchain-accounts-demo repository, https://github.com/cosmos/interchain-accounts-demo, for its ICA tests.

Ibc-go v6 introduced MsgRegsiterinterchainAccount and MsgSendTx to interact with interchain accounts. The current ICA tests in Hermes could be improved to use simd v6+ and any chain using ibc-go v6+.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@ljoss17 ljoss17 added O: ics27-ica Objective: ICS 027, Interchain Accounts O: testability Objective: cause to provide more testing tools and extensions labels May 22, 2023
@ljoss17 ljoss17 self-assigned this May 22, 2023
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Hermes May 22, 2023
@Farhad-Shabani Farhad-Shabani mentioned this issue Jun 1, 2023
Closed
@seanchen1991 seanchen1991 moved this from 🩹 Triage to 📥 Todo in Hermes Jun 6, 2023
@ljoss17 ljoss17 mentioned this issue Jun 13, 2023
Merged
7 tasks
@github-project-automation github-project-automation bot moved this from 📥 Todo to ✅ Done in Hermes Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ljoss17 ljoss17

Labels
O: ics27-ica Objective: ICS 027, Interchain Accounts O: testability Objective: cause to provide more testing tools and extensions
Projects
Hermes
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve ICA tests informalsystems/hermes
1 participant
@ljoss17