Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ICA tests #3415

Merged
merged 10 commits into from
Jun 15, 2023
Merged

Improve ICA tests #3415

merged 10 commits into from
Jun 15, 2023

Conversation

ljoss17
Copy link
Contributor

@ljoss17 ljoss17 commented Jun 13, 2023 •
edited
Loading

Closes: #3353

Description

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@ljoss17 ljoss17 added O: ics27-ica Objective: ICS 027, Interchain Accounts O: testability Objective: cause to provide more testing tools and extensions labels Jun 13, 2023
@ljoss17 ljoss17 requested a review from romac June 14, 2023 07:47
@ljoss17 ljoss17 marked this pull request as ready for review June 14, 2023 07:49
@ljoss17 ljoss17 merged commit 2961796 into master Jun 15, 2023
@ljoss17 ljoss17 deleted the luca_joss/improve-ica-tests branch June 15, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romac romac romac approved these changes

Assignees
No one assigned
Labels
O: ics27-ica Objective: ICS 027, Interchain Accounts O: testability Objective: cause to provide more testing tools and extensions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve ICA tests
2 participants
@ljoss17 @romac