Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ranges for excluded_sequences config option #4047

Closed
5 tasks done
romac opened this issue Jun 18, 2024 · 0 comments · Fixed by #4051
Closed
5 tasks done

Allow ranges for excluded_sequences config option #4047

romac opened this issue Jun 18, 2024 · 0 comments · Fixed by #4051
Labels
I: configuration Internal: related to Hermes configuration O: new-feature Objective: cause to add a new feature or support
Milestone

Comments

@romac
Copy link
Member

romac commented Jun 18, 2024

Summary

Allow ranges for excluded_sequences config option instead of having to specify each sequence number manually.

Problem Definition

Some operators need to exclude large sequence ranges which are unpractical to specify one by one, eg. we've head of ranges which span 32k sequence numbers.

Proposal

Change the deserialization code for excluded_sequences to allow each element of the list to be either:

  • a single sequence number, as an integer: e.g. 123456
  • a range of sequence numbers, as a string: e.g. "123..456"

Let's discuss:

  • what separator to use (.., ..=, -)
  • whether or not the range should be inclusive
  • whether to allow both inclusive and exclusive ranges

Acceptance Criteria

The following value for excluded_sequences is accepted:

excluded_sequences = [
  1, 2, 3, 4, 5,
  "6..9",
  10
]

and is equivalent to specifying:

excluded_sequences = [
  1, 2, 3, 4, 5,
  6, 7, 8, 9,
  10
]

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@romac romac added O: new-feature Objective: cause to add a new feature or support I: configuration Internal: related to Hermes configuration labels Jun 18, 2024
@romac romac added this to the v1.10 milestone Jun 18, 2024
@romac romac added this to Hermes Jun 18, 2024
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Hermes Jun 18, 2024
@github-project-automation github-project-automation bot moved this from 🩹 Triage to ✅ Done in Hermes Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: configuration Internal: related to Hermes configuration O: new-feature Objective: cause to add a new feature or support
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

1 participant