-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow ranges for excluded_sequences
config option
#4051
Conversation
I am a bit wary of supporting both Still, I would rather we keep a single syntax for defining ranges. How about keeping only What do you think @ljoss17? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments above. Great job otherwise!
I agree, having a single separator will make it cleaner. Yes the |
Closes: #4047
Description
This PR changes the type of
excluded_sequences
in the configuration to be aExcludedSequences
which has custom serialisation and deserialisation. This allows the usage of ranges of sequences in addition to exact values.It is now possible to specify excluded sequences using:
[1, 2, 3]
"..="
, e.g.["1..=3"]
".."
, e.g.["1..3"]
"-"
, e.g.["1-3"]
These 4 examples will result in the same result.
PR author checklist:
unclog
.docs/
).Reviewer checklist:
Files changed
in the GitHub PR explorer.