Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use gRPC query ConnectionParams instead of /genesis to verify max_block_time #4143

Closed
5 tasks
ljoss17 opened this issue Aug 13, 2024 · 0 comments · Fixed by #4144
Closed
5 tasks

Use gRPC query ConnectionParams instead of /genesis to verify max_block_time #4143

ljoss17 opened this issue Aug 13, 2024 · 0 comments · Fixed by #4144

Comments

@ljoss17
Copy link
Contributor

ljoss17 commented Aug 13, 2024

Summary

In the current version of Hermes, v1.10.1, the entire genesis data is queried from /genesis in order to verify the max_block_time configuration, https://github.com/informalsystems/hermes/blob/v1.10.1/crates/relayer/src/chain/cosmos.rs#L299-L323.

Since genesis data is bigger and bigger, Hermes should use the gRPC query ConnectionParams to retrieve only the maxExpectedTimePerBlock and use that value to verify the configured value.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Hermes
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use gRPC query ConnectionParams instead of /genesis to verify max_block_time informalsystems/hermes
1 participant
@ljoss17